Conversation
dance858
changed the title
Transurgeon
approved these changes
Jan 6, 2026
Collaborator
Transurgeon
left a comment
Transurgeon
left a comment
There was a problem hiding this comment.
LGTM! I just did a quick sanity check. I think it is a good design choice to have the constant become A^TQA.. but we will need to keep that in mind once we start adding the linear operators.
Transurgeon
reviewed
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First I supported quad_form(Ax, Q), but after reconsideration I think we should treat this as quad_form(x, A^T Q a) in the canonicalization.
So this code now assumes that the first argument to quad_form is a variable by itself, not a linear operator.